fix(prompts): arrow-key navigation no longer duplicates selection options - #16
Conversation
The 0.x @clack/prompts select renderer leaves stale option rows on screen when moving with the arrow keys, so the editor and worktree pickers showed repeated entries. Upstream fixed the renderer in 1.x with no backport, so move to @clack/prompts 1.7 and adapt the two text validators to its narrower value type.
🦋 Changeset detectedLatest commit: 378ab44 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change upgrades ChangesSetup prompt updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This updates interactive prompts to prevent duplicated list options and makes setup validation tolerate nullish values without changing required-field or directory validation behavior. The change is ready to merge. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes in 378ab44, covering the prompt dependency upgrade, its type adaptation, and release metadata.
- Prompt rendering fix: Upgrades
@clack/promptsfrom 0.9.1 to 1.7.0 and updates the lockfile to use the corresponding 1.x core implementation. - Validator compatibility: Handles the 1.x
textvalidator’s optional input while preserving the existing base-branch and directory validation behavior. - Release metadata: Adds a patch changeset describing the interactive selection fix.
GPT Sol ｜ 𝕏
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Choosing from an interactive list (the editor picker in
open, the worktree picker, thesetupprompts) left stale rows on screen as soon as you moved with the arrow keys, so options appeared two or three times and it was unclear what was selected. I traced it to theselectrenderer in@clack/prompts0.x, which upstream fixed in 1.x with no backport planned, and upgraded the dependency to 1.7.0 with the small type adaptation its narrowervalidatesignature required.What changed
setuptext prompts keep the same validation behavior under the new library typesHow to verify
bun run typecheck,bun run lint, andbun run format:checkall pass;bun testreports 96 pass, 0 failSummary by CodeRabbit